[PATCH] Add AArch32 DCPS{1,2,3} and HLT instructions

[Richard Barton]

Hi Tim

Oh dear :-( 

You are right, and those encodings were not being checked. They were also
wrong. 

Updated patch attached.

Thanks
Rich

> -----Original Message-----
> From: Tim Northover [mailto:t.p.northover at gmail.com]
> Sent: 05 September 2013 13:19
> To: Richard Barton
> Cc: llvm-commits
> Subject: Re: [PATCH] Add AArch32 DCPS{1,2,3} and HLT instructions
> 
> Hi Rich,
> 
> > The attached patch adds ARMv8 AArch32 DCPS and HLT instructions to the
> > backend.
> 
> The code changes look OK. These are special instructions (they need to be
> insertable absolutely anywhere to be fully useful, hence the weird
predication
> rules and the allocation of quite a chunk of 16-bit Thumb space I
suspect), so the
> AsmParser hack isn't unduly worrying.
> 
> One question on the tests:
> 
> +0x01 0x80 0x8f 0xf7
> +# CHECK dcps1
> 
> Doesn't FileCheck need a colon to spot a CHECK line?
> 
> Cheers.
> 
> Tim.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: LLVM-843-HLT-DCPS.patch
Type: application/octet-stream
Size: 10896 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130905/3ebe2cbf/attachment.obj>