[PATCH] Add AArch32 DCPS{1,2,3} and HLT instructions
Tim Northover
t.p.northover at gmail.com
Thu Sep 5 05:19:26 PDT 2013
Hi Rich,
> The attached patch adds ARMv8 AArch32 DCPS and HLT instructions to the
> backend.
The code changes look OK. These are special instructions (they need to
be insertable absolutely anywhere to be fully useful, hence the weird
predication rules and the allocation of quite a chunk of 16-bit Thumb
space I suspect), so the AsmParser hack isn't unduly worrying.
One question on the tests:
+0x01 0x80 0x8f 0xf7
+# CHECK dcps1
Doesn't FileCheck need a colon to spot a CHECK line?
Cheers.
Tim.
More information about the llvm-commits
mailing list