[LLD] Cyclic dependency between ReaderWriter and YAML backend

Nick Kledzik kledzik at apple.com
Tue Sep 3 13:31:27 PDT 2013


On Sep 3, 2013, at 1:21 PM, Rui Ueyama <ruiu at google.com> wrote:
> As I suggested before, we can solve the circular dependency problem here by moving CoreLinkingContext.cpp to its own library, no?

We really need a new subdir/library under ReaderWriter for the “core” command line driver.

The term “core” is overloaded.  It means the central linking engine and the command line driver for testing the core engine.

-Nick



> 
> 
> On Tue, Sep 3, 2013 at 1:03 PM, Joerg Sonnenberger <joerg at britannica.bec.de> wrote:
> On Tue, Sep 03, 2013 at 12:53:34PM -0700, Nick Kledzik wrote:
> > Joerg has not posted what the circular dependency is.  Maybe it can be
> > fixed by moving some trivial code around.
> 
> ReaderWriterYAML.cpp.o has undefined references to Reader::~Reader and
> Writer::~Writer. CoreLinkingcontext.cpp.o has undefined references to
> createReaderYAML and createWriterYAML. They are in separate libraries.
> 
> The trivial move is what the original patch does -- embedded the YAML
> reader/writer into libReaderWriter directly.
> 
> Joerg
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130903/8f572a82/attachment.html>


More information about the llvm-commits mailing list