<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Sep 3, 2013, at 1:21 PM, Rui Ueyama <<a href="mailto:ruiu@google.com">ruiu@google.com</a>> wrote:</div><blockquote type="cite"><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div dir="ltr">As I suggested before, we can solve the circular dependency problem here by moving CoreLinkingContext.cpp to its own library, no?</div></div></blockquote><div><br></div><div>We really need a new subdir/library under ReaderWriter for the “core” command line driver.</div><div><br></div><div><div>The term “core” is overloaded. It means the central linking engine and the command line driver for testing the core engine.</div><div><br></div><div>-Nick</div></div><div><br></div><div><br></div><br><blockquote type="cite"><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Sep 3, 2013 at 1:03 PM, Joerg Sonnenberger<span class="Apple-converted-space"> </span><span dir="ltr"><<a href="mailto:joerg@britannica.bec.de" target="_blank">joerg@britannica.bec.de</a>></span><span class="Apple-converted-space"> </span>wrote:<br><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><div class="im">On Tue, Sep 03, 2013 at 12:53:34PM -0700, Nick Kledzik wrote:<br>> Joerg has not posted what the circular dependency is. Maybe it can be<br>> fixed by moving some trivial code around.<br><br></div>ReaderWriterYAML.cpp.o has undefined references to Reader::~Reader and<br>Writer::~Writer. CoreLinkingcontext.cpp.o has undefined references to<br>createReaderYAML and createWriterYAML. They are in separate libraries.<br><br>The trivial move is what the original patch does -- embedded the YAML<br>reader/writer into libReaderWriter directly.<br><span class="HOEnZb"><font color="#888888"><br>Joerg<br></font></span><div class="HOEnZb"><div class="h5">_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br></div></div></blockquote></div><br></div>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></div></blockquote></div><br></body></html>