[compiler-rt] r189475 - Check code style in check-sanitizer command

[Peter Collingbourne]

On Thu, Aug 29, 2013 at 02:46:53PM -0700, Peter Collingbourne wrote:
> On Wed, Aug 28, 2013 at 11:27:32AM -0000, Alexey Samsonov wrote:
> > Author: samsonov
> > Date: Wed Aug 28 06:27:31 2013
> > New Revision: 189475
> > 
> > URL: http://llvm.org/viewvc/llvm-project?rev=189475&view=rev
> > Log:
> > Check code style in check-sanitizer command
> > 
> > Added:
> >     compiler-rt/trunk/lib/sanitizer_common/scripts/cpplint.py   (with props)
> > Modified:
> >     compiler-rt/trunk/lib/sanitizer_common/CMakeLists.txt
> >     compiler-rt/trunk/lib/sanitizer_common/scripts/check_lint.sh
> >     compiler-rt/trunk/lib/sanitizer_common/tests/CMakeLists.txt
> > 
> > Modified: compiler-rt/trunk/lib/sanitizer_common/CMakeLists.txt
> > URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/CMakeLists.txt?rev=189475&r1=189474&r2=189475&view=diff
> > ==============================================================================
> > --- compiler-rt/trunk/lib/sanitizer_common/CMakeLists.txt (original)
> > +++ compiler-rt/trunk/lib/sanitizer_common/CMakeLists.txt Wed Aug 28 06:27:31 2013
> > @@ -100,6 +100,16 @@ else()
> >    endforeach()
> >  endif()
> >  
> > +# Add target to check code style for sanitizer runtimes.
> > +if(UNIX)
> > +  set(SANITIZER_LINT_SCRIPT ${CMAKE_CURRENT_SOURCE_DIR}/scripts/check_lint.sh)
> > +  add_custom_target(SanitizerLintCheck ALL
> 
> Why did you add this target to "all"?  It seriously slows down the
> default build.  I think it should only be part of one of the check-*
> targets.

Disregard; I forgot to update.

Thanks,
-- 
Peter