[PATCH] ARM: use new modified-imm instructions for all MC-level purposes.
Renato Golin
renato.golin at linaro.org
Tue Aug 27 05:40:37 PDT 2013
Hi Tim,
Overall, I like this change and I agree it's the way forward. I had some
nitpick comments in phabricator, but I'm happy with the patch as it is.
Feel free to ignore whatever doesn't make sense.
cheers,
--renato
On 17 August 2013 16:33, Tim Northover <t.p.northover at gmail.com> wrote:
> Noticed a couple of tidy ups just after posting. Isn't it always the way?
> + use "ARMModifiedImm" instead of "ModifiedImm" in printing. There's a
> Thumb one too.
> + An 80-col thing, that I'd even annotated "FIXME".
>
> Hi grosbach,
>
> http://llvm-reviews.chandlerc.com/D1432
>
> CHANGE SINCE LAST DIFF
> http://llvm-reviews.chandlerc.com/D1432?vs=3545&id=3547#toc
>
> Files:
> lib/Target/ARM/ARMCodeEmitter.cpp
> lib/Target/ARM/ARMInstrInfo.td
> lib/Target/ARM/AsmParser/ARMAsmParser.cpp
> lib/Target/ARM/Disassembler/ARMDisassembler.cpp
> lib/Target/ARM/InstPrinter/ARMInstPrinter.cpp
> lib/Target/ARM/InstPrinter/ARMInstPrinter.h
> lib/Target/ARM/MCTargetDesc/ARMMCCodeEmitter.cpp
> test/MC/ARM/basic-arm-instructions.s
> test/MC/ARM/diagnostics.s
> test/MC/Disassembler/ARM/arm-tests.txt
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130827/68294ce4/attachment.html>
More information about the llvm-commits
mailing list