<div dir="ltr">Hi Tim,<div><br></div><div>Overall, I like this change and I agree it's the way forward. I had some nitpick comments in phabricator, but I'm happy with the patch as it is. Feel free to ignore whatever doesn't make sense.</div>
<div><br></div><div>cheers,</div><div>--renato</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On 17 August 2013 16:33, Tim Northover <span dir="ltr"><<a href="mailto:t.p.northover@gmail.com" target="_blank">t.p.northover@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">  Noticed a couple of tidy ups just after posting. Isn't it always the way?<br>
    + use "ARMModifiedImm" instead of "ModifiedImm" in printing. There's a Thumb one too.<br>
    + An 80-col thing, that I'd even annotated "FIXME".<br>
<br>
Hi grosbach,<br>
<br>
<a href="http://llvm-reviews.chandlerc.com/D1432" target="_blank">http://llvm-reviews.chandlerc.com/D1432</a><br>
<br>
CHANGE SINCE LAST DIFF<br>
  <a href="http://llvm-reviews.chandlerc.com/D1432?vs=3545&id=3547#toc" target="_blank">http://llvm-reviews.chandlerc.com/D1432?vs=3545&id=3547#toc</a><br>
<div class="im"><br>
Files:<br>
  lib/Target/ARM/ARMCodeEmitter.cpp<br>
  lib/Target/ARM/ARMInstrInfo.td<br>
  lib/Target/ARM/AsmParser/ARMAsmParser.cpp<br>
  lib/Target/ARM/Disassembler/ARMDisassembler.cpp<br>
  lib/Target/ARM/InstPrinter/ARMInstPrinter.cpp<br>
  lib/Target/ARM/InstPrinter/ARMInstPrinter.h<br>
  lib/Target/ARM/MCTargetDesc/ARMMCCodeEmitter.cpp<br>
  test/MC/ARM/basic-arm-instructions.s<br>
  test/MC/ARM/diagnostics.s<br>
</div>  test/MC/Disassembler/ARM/arm-tests.txt<br>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>