[PATCH] [PECOFF] support additional subsystem identifiers

Rui Ueyama ruiu at google.com
Thu Aug 22 15:10:40 PDT 2013


LGTM.


On Sun, Aug 18, 2013 at 2:42 PM, Saleem Abdulrasool
<compnerd at compnerd.org>wrote:

> Hi ruiu,
>
> This completes the subsystem name parsing to support the identifiers that
> the
> Microsoft link.exe linker supports.  "windows" and "console" are left as
> the
> first items as they are the expected common paths.
>
> Signed-off-by: Saleem Abdulrasool <compnerd at compnerd.org>
>
>
> http://llvm-reviews.chandlerc.com/D1435
>
> Files:
>   lib/Driver/WinLinkDriver.cpp
>
> Index: lib/Driver/WinLinkDriver.cpp
> ===================================================================
> --- lib/Driver/WinLinkDriver.cpp
> +++ lib/Driver/WinLinkDriver.cpp
> @@ -141,6 +141,16 @@
>    return llvm::StringSwitch<llvm::COFF::WindowsSubsystem>(arg)
>        .Case("windows", llvm::COFF::IMAGE_SUBSYSTEM_WINDOWS_GUI)
>        .Case("console", llvm::COFF::IMAGE_SUBSYSTEM_WINDOWS_CUI)
> +      .Case("boot_application",
> +            llvm::COFF::IMAGE_SUBSYSTEM_WINDOWS_BOOT_APPLICATION)
> +      .Case("efi_application",
> llvm::COFF::IMAGE_SUBSYSTEM_EFI_APPLICATION)
> +      .Case("efi_boot_service_driver",
> +            llvm::COFF::IMAGE_SUBSYSTEM_EFI_BOOT_SERVICE_DRIVER)
> +      .Case("efi_rom", llvm::COFF::IMAGE_SUBSYSTEM_EFI_ROM)
> +      .Case("efi_runtime_driver",
> +            llvm::COFF::IMAGE_SUBSYSTEM_EFI_RUNTIME_DRIVER)
> +      .Case("native", llvm::COFF::IMAGE_SUBSYSTEM_NATIVE)
> +      .Case("posix", llvm::COFF::IMAGE_SUBSYSTEM_POSIX_CUI)
>        .Default(llvm::COFF::IMAGE_SUBSYSTEM_UNKNOWN);
>  }
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130822/da82effd/attachment.html>


More information about the llvm-commits mailing list