<div dir="ltr">LGTM.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sun, Aug 18, 2013 at 2:42 PM, Saleem Abdulrasool <span dir="ltr"><<a href="mailto:compnerd@compnerd.org" target="_blank">compnerd@compnerd.org</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi ruiu,<br>
<br>
This completes the subsystem name parsing to support the identifiers that the<br>
Microsoft link.exe linker supports.  "windows" and "console" are left as the<br>
first items as they are the expected common paths.<br>
<br>
Signed-off-by: Saleem Abdulrasool <<a href="mailto:compnerd@compnerd.org">compnerd@compnerd.org</a>><br>
<br>
<br>
<a href="http://llvm-reviews.chandlerc.com/D1435" target="_blank">http://llvm-reviews.chandlerc.com/D1435</a><br>
<br>
Files:<br>
  lib/Driver/WinLinkDriver.cpp<br>
<br>
Index: lib/Driver/WinLinkDriver.cpp<br>
===================================================================<br>
--- lib/Driver/WinLinkDriver.cpp<br>
+++ lib/Driver/WinLinkDriver.cpp<br>
@@ -141,6 +141,16 @@<br>
   return llvm::StringSwitch<llvm::COFF::WindowsSubsystem>(arg)<br>
       .Case("windows", llvm::COFF::IMAGE_SUBSYSTEM_WINDOWS_GUI)<br>
       .Case("console", llvm::COFF::IMAGE_SUBSYSTEM_WINDOWS_CUI)<br>
+      .Case("boot_application",<br>
+            llvm::COFF::IMAGE_SUBSYSTEM_WINDOWS_BOOT_APPLICATION)<br>
+      .Case("efi_application", llvm::COFF::IMAGE_SUBSYSTEM_EFI_APPLICATION)<br>
+      .Case("efi_boot_service_driver",<br>
+            llvm::COFF::IMAGE_SUBSYSTEM_EFI_BOOT_SERVICE_DRIVER)<br>
+      .Case("efi_rom", llvm::COFF::IMAGE_SUBSYSTEM_EFI_ROM)<br>
+      .Case("efi_runtime_driver",<br>
+            llvm::COFF::IMAGE_SUBSYSTEM_EFI_RUNTIME_DRIVER)<br>
+      .Case("native", llvm::COFF::IMAGE_SUBSYSTEM_NATIVE)<br>
+      .Case("posix", llvm::COFF::IMAGE_SUBSYSTEM_POSIX_CUI)<br>
       .Default(llvm::COFF::IMAGE_SUBSYSTEM_UNKNOWN);<br>
 }<br>
</blockquote></div><br></div>