XCore target: fix weak linkage attribute handling

[Robert Lytton]

Hi Richard,

We must still override the WeakRefDirective to get a directive emitted for weak references.

I've extended the tests to check output for both weak definitions & weak references for both functions & variables.

Robert

________________________________
From: Richard Osborne
Sent: 16 August 2013 17:07
To: Robert Lytton
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: XCore target: fix weak linkage attribute handling

Looks good to me.


--- a/lib/Target/XCore/MCTargetDesc/XCoreMCAsmInfo.cpp
+++ b/lib/Target/XCore/MCTargetDesc/XCoreMCAsmInfo.cpp
@@ -23,7 +23,6 @@ XCoreMCAsmInfo::XCoreMCAsmInfo(StringRef TT) {

   PrivateGlobalPrefix = ".L";
   AscizDirective = ".asciiz";
-  WeakDefDirective = "\t.weak\t";
   WeakRefDirective = "\t.weak\t";

Should we also remove the override of the WeakRefDirective, or is this still needed?

On 16/08/13 16:57, Robert Lytton wrote:
Hi,

Here is a patch to remove WeakDefDirective as there is no directive.

Robert



_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu>
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




--
Richard Osborne | XMOS
http://www.xmos.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130819/8558f369/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PatchWeakLinkage
Type: application/octet-stream
Size: 962 bytes
Desc: PatchWeakLinkage
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130819/8558f369/attachment.obj>