<html dir="ltr">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
<body ocsi="0" fpstyle="1" bgcolor="#FFFFFF">
<div style="direction: ltr;font-family: Tahoma;color: #000000;font-size: 10pt;">Hi Richard,<br>
<br>
We must still override the WeakRefDirective to get a directive emitted for weak references.<br>
<br>
I've extended the tests to check output for both weak definitions & weak references for both functions & variables.<br>
<br>
Robert<br>
<br>
<div style="font-family: Times New Roman; color: #000000; font-size: 16px">
<hr tabindex="-1">
<div style="direction: ltr;" id="divRpF217026"><font color="#000000" face="Tahoma" size="2"><b>From:</b> Richard Osborne<br>
<b>Sent:</b> 16 August 2013 17:07<br>
<b>To:</b> Robert Lytton<br>
<b>Cc:</b> llvm-commits@cs.uiuc.edu<br>
<b>Subject:</b> Re: XCore target: fix weak linkage attribute handling<br>
</font><br>
</div>
<div></div>
<div>
<div class="moz-cite-prefix">Looks good to me.<br>
<br>
<br>
--- a/lib/Target/XCore/MCTargetDesc/XCoreMCAsmInfo.cpp<br>
+++ b/lib/Target/XCore/MCTargetDesc/XCoreMCAsmInfo.cpp<br>
@@ -23,7 +23,6 @@ XCoreMCAsmInfo::XCoreMCAsmInfo(StringRef TT) {<br>
<br>
PrivateGlobalPrefix = ".L";<br>
AscizDirective = ".asciiz";<br>
- WeakDefDirective = "\t.weak\t";<br>
WeakRefDirective = "\t.weak\t";<br>
<br>
Should we also remove the override of the WeakRefDirective, or is this still needed?<br>
<br>
On 16/08/13 16:57, Robert Lytton wrote:<br>
</div>
<blockquote type="cite"><style id="owaParaStyle" type="text/css">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
BODY {direction: ltr;font-family: Tahoma;color: #000000;font-size: 10pt;}P {margin-top:0;margin-bottom:0;}</style>
<div style="direction:ltr; font-family:Tahoma; color:#000000; font-size:10pt">Hi,<br>
<br>
Here is a patch to remove WeakDefDirective as there is no directive.<br>
<br>
Robert<br>
</div>
<br>
<fieldset class="mimeAttachmentHeader" target="_blank"></fieldset> <br>
<pre>_______________________________________________
llvm-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a>
</pre>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Richard Osborne | XMOS
<a class="moz-txt-link-freetext" href="http://www.xmos.com" target="_blank">http://www.xmos.com</a>
</pre>
</div>
</div>
</div>
</body>
</html>