[PATCH] some cleanups in regalloc code

[Matthias Braun]

Actually I do have separate commits in my local git repo, but that phabricator arc thingy apparently merged them into one thing, and I assumed grouping multiple commits together while still having them as separate commits is just is not supported by it…

I attached the single commits in git format-patch format.

Greetings
	Matthias



On Aug 13, 2013, at 4:22 PM, Jakob Stoklund Olesen <stoklund at 2pi.dk> wrote:

> 
> On Aug 13, 2013, at 3:57 PM, Matthias Braun <mbraun at apple.com> wrote:
> 
>> MatzeB added you to the CC list for the revision "some cleanups in regalloc code".
>> 
>> Just some small cleanups of stuff I spotted while reading register allocation
>> code:
>> 
>> remove unused struct/enum
>> 
>> LiveIntervalUnion is not used in RegAllocBase
>> 
>> remove declaration of nonexistant function
>> 
>> improve misleading comment
>> 
>> remove unused function
>> 
>> remove unnecessary parameter to RenumberValues
>> 
>> http://llvm-reviews.chandlerc.com/D1393
>> 
>> Files:
>> include/llvm/CodeGen/LiveInterval.h
>> lib/CodeGen/LiveInterval.cpp
>> lib/CodeGen/LiveIntervalAnalysis.cpp
>> lib/CodeGen/LiveRangeCalc.h
>> lib/CodeGen/LiveRangeEdit.cpp
>> lib/CodeGen/RegAllocBase.h
>> lib/CodeGen/SplitKit.cpp
> 
> Hi Matthias,
> 
> This all looks good to me, but it should be broken into separate commits.
> 
> Thanks,
> /jakob
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130813/a5cd56d1/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-remove-unused-struct-enum.patch
Type: application/octet-stream
Size: 897 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130813/a5cd56d1/attachment.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130813/a5cd56d1/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-LiveIntervalUnion-is-not-used-in-RegAllocBase.patch
Type: application/octet-stream
Size: 720 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130813/a5cd56d1/attachment-0001.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130813/a5cd56d1/attachment-0002.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-remove-declaration-of-nonexistant-function.patch
Type: application/octet-stream
Size: 935 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130813/a5cd56d1/attachment-0002.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130813/a5cd56d1/attachment-0003.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-improve-misleading-comment.patch
Type: application/octet-stream
Size: 805 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130813/a5cd56d1/attachment-0003.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130813/a5cd56d1/attachment-0004.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-remove-unused-function.patch
Type: application/octet-stream
Size: 1171 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130813/a5cd56d1/attachment-0004.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130813/a5cd56d1/attachment-0005.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-some-cleanups-in-regalloc-code.patch
Type: application/octet-stream
Size: 3020 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130813/a5cd56d1/attachment-0005.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130813/a5cd56d1/attachment-0006.html>