[PATCH] some cleanups in regalloc code
Jakob Stoklund Olesen
stoklund at 2pi.dk
Tue Aug 13 16:22:58 PDT 2013
On Aug 13, 2013, at 3:57 PM, Matthias Braun <mbraun at apple.com> wrote:
> MatzeB added you to the CC list for the revision "some cleanups in regalloc code".
>
> Just some small cleanups of stuff I spotted while reading register allocation
> code:
>
> remove unused struct/enum
>
> LiveIntervalUnion is not used in RegAllocBase
>
> remove declaration of nonexistant function
>
> improve misleading comment
>
> remove unused function
>
> remove unnecessary parameter to RenumberValues
>
> http://llvm-reviews.chandlerc.com/D1393
>
> Files:
> include/llvm/CodeGen/LiveInterval.h
> lib/CodeGen/LiveInterval.cpp
> lib/CodeGen/LiveIntervalAnalysis.cpp
> lib/CodeGen/LiveRangeCalc.h
> lib/CodeGen/LiveRangeEdit.cpp
> lib/CodeGen/RegAllocBase.h
> lib/CodeGen/SplitKit.cpp
Hi Matthias,
This all looks good to me, but it should be broken into separate commits.
Thanks,
/jakob
More information about the llvm-commits
mailing list