[PATCH] Add ALL to FileCheck

[Stephen Lin]

> This is an undocumented feature that is being removed as we speak, and as
> Tim said, FileCheck is getting more strict, which is a good thing.

What's the undocumented feature being removed exactly? Does FileCheck
currently allow more than one prefix on the command line.

>
> I think by having a documented "ALL" flag, and by forcing the use of it on
> the test (as opposed to CHECK), we'll have a clearer picture and will be
> able to enforce better tests.
>
> You could say that "CHECK" is that "ALL" flag, but "CHECK" is also the
> default for the --check-prefix, and IMHO that makes it a bad candidate
> (confusion when writing tests, confusion when changing FileCheck, etc).

I'm not sure you understand what I mean. I'm not suggesting that
"CHECK" be the "ALL" flag. I'm suggesting that there be no flag that
is just implicitly turned on (other than "CHECK" when no
user-specified prefix is provided)

I don't like that there's a magic string with special meaning, and I
think that goes against the stated intention of making FileCheck more
strict (which to me implies that behavior should be opt-in and
specifically asked for rather than implicit and opt-out). My
suggestion is that if you want a secondary prefix is that is used
during the execution of a specific invocation of FileCheck that you
need to ask for it specifically.

>
> cheers,
> --renato