[PATCH] Add ALL to FileCheck

[Renato Golin]

Matt, Stephen,

I like the idea, as I wanted that for my tests before.


On 13 August 2013 06:18, Stephen Lin <swlin at post.harvard.edu> wrote:

> Just to clarify, the idea would be that with no check prefix on the
> command line, the prefix will default to "CHECK" as it does currently;
> with one or more prefix specified on the command line, there will be
> no implied CHECK prefix but will instead be the one or more prefix(es)
> specified.
>

This is an undocumented feature that is being removed as we speak, and as
Tim said, FileCheck is getting more strict, which is a good thing.

I think by having a documented "ALL" flag, and by forcing the use of it on
the test (as opposed to CHECK), we'll have a clearer picture and will be
able to enforce better tests.

You could say that "CHECK" is that "ALL" flag, but "CHECK" is also the
default for the --check-prefix, and IMHO that makes it a bad candidate
(confusion when writing tests, confusion when changing FileCheck, etc).

cheers,
--renato
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130813/e86e7045/attachment.html>