[llvm] r187852 - [lit] Drop --no-execute, which isn't generally useful.

[Daniel Dunbar]

Yup, sorry about that.

In the longer term is it possible for you to migrate to "--show-tests
--max-tests 0", if that is what you are using it for?

 - Daniel



On Wed, Aug 7, 2013 at 4:26 AM, NAKAMURA Takumi <geek4civic at gmail.com>wrote:

> Oh, my builders were using it... May I resurrect it?
>
> 2013/8/7 Daniel Dunbar <daniel at zuster.org>:
> > Author: ddunbar
> > Date: Tue Aug  6 22:14:00 2013
> > New Revision: 187852
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=187852&view=rev
> > Log:
> > [lit] Drop --no-execute, which isn't generally useful.
> >
> > Modified:
> >     llvm/trunk/utils/lit/lit/LitConfig.py
> >     llvm/trunk/utils/lit/lit/TestFormats.py
> >     llvm/trunk/utils/lit/lit/TestRunner.py
> >     llvm/trunk/utils/lit/lit/discovery.py
> >     llvm/trunk/utils/lit/lit/main.py
> >
> > Modified: llvm/trunk/utils/lit/lit/LitConfig.py
> > URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/LitConfig.py?rev=187852&r1=187851&r2=187852&view=diff
> >
> ==============================================================================
> > --- llvm/trunk/utils/lit/lit/LitConfig.py (original)
> > +++ llvm/trunk/utils/lit/lit/LitConfig.py Tue Aug  6 22:14:00 2013
> > @@ -19,8 +19,7 @@ class LitConfig:
> >
> >      def __init__(self, progname, path, quiet,
> >                   useValgrind, valgrindLeakCheck, valgrindArgs,
> > -                 noExecute, debug, isWindows,
> > -                 params, config_prefix = None):
> > +                 debug, isWindows, params, config_prefix = None):
> >          # The name of the test runner.
> >          self.progname = progname
> >          # The items to add to the PATH environment variable.
> > @@ -29,7 +28,6 @@ class LitConfig:
> >          self.useValgrind = bool(useValgrind)
> >          self.valgrindLeakCheck = bool(valgrindLeakCheck)
> >          self.valgrindUserArgs = list(valgrindArgs)
> > -        self.noExecute = noExecute
> >          self.debug = debug
> >          self.isWindows = bool(isWindows)
> >          self.params = dict(params)
> >
> > Modified: llvm/trunk/utils/lit/lit/TestFormats.py
> > URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/TestFormats.py?rev=187852&r1=187851&r2=187852&view=diff
> >
> ==============================================================================
> > --- llvm/trunk/utils/lit/lit/TestFormats.py (original)
> > +++ llvm/trunk/utils/lit/lit/TestFormats.py Tue Aug  6 22:14:00 2013
> > @@ -99,9 +99,6 @@ class GoogleTest(object):
> >          if litConfig.useValgrind:
> >              cmd = litConfig.valgrindArgs + cmd
> >
> > -        if litConfig.noExecute:
> > -            return Test.PASS, ''
> > -
> >          out, err, exitCode = TestRunner.executeCommand(
> >              cmd, env=test.config.environment)
> >
> >
> > Modified: llvm/trunk/utils/lit/lit/TestRunner.py
> > URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/TestRunner.py?rev=187852&r1=187851&r2=187852&view=diff
> >
> ==============================================================================
> > --- llvm/trunk/utils/lit/lit/TestRunner.py (original)
> > +++ llvm/trunk/utils/lit/lit/TestRunner.py Tue Aug  6 22:14:00 2013
> > @@ -465,9 +465,6 @@ def executeShTest(test, litConfig, useEx
> >
> >      script, isXFail, tmpBase, execdir = res
> >
> > -    if litConfig.noExecute:
> > -        return (Test.PASS, '')
> > -
> >      # Create the output directory if it does not already exist.
> >      Util.mkdir_p(os.path.dirname(tmpBase))
> >
> >
> > Modified: llvm/trunk/utils/lit/lit/discovery.py
> > URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/discovery.py?rev=187852&r1=187851&r2=187852&view=diff
> >
> ==============================================================================
> > --- llvm/trunk/utils/lit/lit/discovery.py (original)
> > +++ llvm/trunk/utils/lit/lit/discovery.py Tue Aug  6 22:14:00 2013
> > @@ -232,7 +232,6 @@ def load_test_suite(inputs):
> >                                      useValgrind = False,
> >                                      valgrindLeakCheck = False,
> >                                      valgrindArgs = [],
> > -                                    noExecute = False,
> >                                      debug = False,
> >                                      isWindows =
> (platform.system()=='Windows'),
> >                                      params = {})
> >
> > Modified: llvm/trunk/utils/lit/lit/main.py
> > URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/main.py?rev=187852&r1=187851&r2=187852&view=diff
> >
> ==============================================================================
> > --- llvm/trunk/utils/lit/lit/main.py (original)
> > +++ llvm/trunk/utils/lit/lit/main.py Tue Aug  6 22:14:00 2013
> > @@ -214,9 +214,6 @@ def main(builtinParameters = {}):
> >      group.add_option("", "--time-tests", dest="timeTests",
> >                       help="Track elapsed wall time for each test",
> >                       action="store_true", default=False)
> > -    group.add_option("", "--no-execute", dest="noExecute",
> > -                     help="Don't execute any tests (assume PASS)",
> > -                     action="store_true", default=False)
> >      parser.add_option_group(group)
> >
> >      group = OptionGroup(parser, "Test Selection")
> > @@ -283,7 +280,6 @@ def main(builtinParameters = {}):
> >                                      useValgrind = opts.useValgrind,
> >                                      valgrindLeakCheck =
> opts.valgrindLeakCheck,
> >                                      valgrindArgs = opts.valgrindArgs,
> > -                                    noExecute = opts.noExecute,
> >                                      debug = opts.debug,
> >                                      isWindows =
> (platform.system()=='Windows'),
> >                                      params = userParams,
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130807/4aee6cee/attachment.html>