<div dir="ltr">Yup, sorry about that.<div><br></div><div>In the longer term is it possible for you to migrate to "--show-tests --max-tests 0", if that is what you are using it for?</div><div><br></div><div> - Daniel<br>
<div><br></div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Aug 7, 2013 at 4:26 AM, NAKAMURA Takumi <span dir="ltr"><<a href="mailto:geek4civic@gmail.com" target="_blank">geek4civic@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Oh, my builders were using it... May I resurrect it?<br>
<br>
2013/8/7 Daniel Dunbar <<a href="mailto:daniel@zuster.org">daniel@zuster.org</a>>:<br>
<div class="HOEnZb"><div class="h5">> Author: ddunbar<br>
> Date: Tue Aug 6 22:14:00 2013<br>
> New Revision: 187852<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=187852&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=187852&view=rev</a><br>
> Log:<br>
> [lit] Drop --no-execute, which isn't generally useful.<br>
><br>
> Modified:<br>
> llvm/trunk/utils/lit/lit/LitConfig.py<br>
> llvm/trunk/utils/lit/lit/TestFormats.py<br>
> llvm/trunk/utils/lit/lit/TestRunner.py<br>
> llvm/trunk/utils/lit/lit/discovery.py<br>
> llvm/trunk/utils/lit/lit/main.py<br>
><br>
> Modified: llvm/trunk/utils/lit/lit/LitConfig.py<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/LitConfig.py?rev=187852&r1=187851&r2=187852&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/LitConfig.py?rev=187852&r1=187851&r2=187852&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/utils/lit/lit/LitConfig.py (original)<br>
> +++ llvm/trunk/utils/lit/lit/LitConfig.py Tue Aug 6 22:14:00 2013<br>
> @@ -19,8 +19,7 @@ class LitConfig:<br>
><br>
> def __init__(self, progname, path, quiet,<br>
> useValgrind, valgrindLeakCheck, valgrindArgs,<br>
> - noExecute, debug, isWindows,<br>
> - params, config_prefix = None):<br>
> + debug, isWindows, params, config_prefix = None):<br>
> # The name of the test runner.<br>
> self.progname = progname<br>
> # The items to add to the PATH environment variable.<br>
> @@ -29,7 +28,6 @@ class LitConfig:<br>
> self.useValgrind = bool(useValgrind)<br>
> self.valgrindLeakCheck = bool(valgrindLeakCheck)<br>
> self.valgrindUserArgs = list(valgrindArgs)<br>
> - self.noExecute = noExecute<br>
> self.debug = debug<br>
> self.isWindows = bool(isWindows)<br>
> self.params = dict(params)<br>
><br>
> Modified: llvm/trunk/utils/lit/lit/TestFormats.py<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/TestFormats.py?rev=187852&r1=187851&r2=187852&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/TestFormats.py?rev=187852&r1=187851&r2=187852&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/utils/lit/lit/TestFormats.py (original)<br>
> +++ llvm/trunk/utils/lit/lit/TestFormats.py Tue Aug 6 22:14:00 2013<br>
> @@ -99,9 +99,6 @@ class GoogleTest(object):<br>
> if litConfig.useValgrind:<br>
> cmd = litConfig.valgrindArgs + cmd<br>
><br>
> - if litConfig.noExecute:<br>
> - return Test.PASS, ''<br>
> -<br>
> out, err, exitCode = TestRunner.executeCommand(<br>
> cmd, env=test.config.environment)<br>
><br>
><br>
> Modified: llvm/trunk/utils/lit/lit/TestRunner.py<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/TestRunner.py?rev=187852&r1=187851&r2=187852&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/TestRunner.py?rev=187852&r1=187851&r2=187852&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/utils/lit/lit/TestRunner.py (original)<br>
> +++ llvm/trunk/utils/lit/lit/TestRunner.py Tue Aug 6 22:14:00 2013<br>
> @@ -465,9 +465,6 @@ def executeShTest(test, litConfig, useEx<br>
><br>
> script, isXFail, tmpBase, execdir = res<br>
><br>
> - if litConfig.noExecute:<br>
> - return (Test.PASS, '')<br>
> -<br>
> # Create the output directory if it does not already exist.<br>
> Util.mkdir_p(os.path.dirname(tmpBase))<br>
><br>
><br>
> Modified: llvm/trunk/utils/lit/lit/discovery.py<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/discovery.py?rev=187852&r1=187851&r2=187852&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/discovery.py?rev=187852&r1=187851&r2=187852&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/utils/lit/lit/discovery.py (original)<br>
> +++ llvm/trunk/utils/lit/lit/discovery.py Tue Aug 6 22:14:00 2013<br>
> @@ -232,7 +232,6 @@ def load_test_suite(inputs):<br>
> useValgrind = False,<br>
> valgrindLeakCheck = False,<br>
> valgrindArgs = [],<br>
> - noExecute = False,<br>
> debug = False,<br>
> isWindows = (platform.system()=='Windows'),<br>
> params = {})<br>
><br>
> Modified: llvm/trunk/utils/lit/lit/main.py<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/main.py?rev=187852&r1=187851&r2=187852&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/main.py?rev=187852&r1=187851&r2=187852&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/utils/lit/lit/main.py (original)<br>
> +++ llvm/trunk/utils/lit/lit/main.py Tue Aug 6 22:14:00 2013<br>
> @@ -214,9 +214,6 @@ def main(builtinParameters = {}):<br>
> group.add_option("", "--time-tests", dest="timeTests",<br>
> help="Track elapsed wall time for each test",<br>
> action="store_true", default=False)<br>
> - group.add_option("", "--no-execute", dest="noExecute",<br>
> - help="Don't execute any tests (assume PASS)",<br>
> - action="store_true", default=False)<br>
> parser.add_option_group(group)<br>
><br>
> group = OptionGroup(parser, "Test Selection")<br>
> @@ -283,7 +280,6 @@ def main(builtinParameters = {}):<br>
> useValgrind = opts.useValgrind,<br>
> valgrindLeakCheck = opts.valgrindLeakCheck,<br>
> valgrindArgs = opts.valgrindArgs,<br>
> - noExecute = opts.noExecute,<br>
> debug = opts.debug,<br>
> isWindows = (platform.system()=='Windows'),<br>
> params = userParams,<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>