[PATCH] Rename TargetInfo -> LinkerContext.
Nick Kledzik
kledzik at apple.com
Tue Aug 6 13:48:38 PDT 2013
LGTM.
My only comment is that it would have been nice to discuss the name before you did all this work. For instance, I was wondering if LinkingContext would be better than LinkerContext. I do like have the variables named just “context”.
-Nick
On Aug 6, 2013, at 12:49 PM, Rui Ueyama <ruiu at google.com> wrote:
> So this is a patch to rename the class as we discussed recently. This patch virtually touches all the file and will conflict with any patch. I want to check this in as soon as possible to minimize the possibility of conflicts. I'd appreciate if you could review this quickly. Thanks!
>
>
> On Tue, Aug 6, 2013 at 12:44 PM, Rui Ueyama <ruiu at google.com> wrote:
> Hi kledzik, shankarke, Bigcheese,
>
> Also change some local variable names: "ti" -> "ctx" and
> "_targetInfo" -> "_context".
>
> http://llvm-reviews.chandlerc.com/D1301
>
> Files:
> docs/Driver.rst
> include/lld/Core/ArchiveLibraryFile.h
> include/lld/Core/File.h
> include/lld/Core/LinkerContext.h
> include/lld/Core/TargetInfo.h
> include/lld/Core/Resolver.h
> include/lld/Core/SymbolTable.h
> include/lld/Driver/Driver.h
> include/lld/ReaderWriter/CoreLinkerContext.h
> include/lld/ReaderWriter/CoreTargetInfo.h
> include/lld/ReaderWriter/ELFLinkerContext.h
> include/lld/ReaderWriter/ELFTargetInfo.h
> include/lld/ReaderWriter/MachOLinkerContext.h
> include/lld/ReaderWriter/MachOTargetInfo.h
> include/lld/ReaderWriter/PECOFFLinkerContext.h
> include/lld/ReaderWriter/PECOFFTargetInfo.h
> include/lld/ReaderWriter/Reader.h
> include/lld/ReaderWriter/ReaderArchive.h
> include/lld/ReaderWriter/ReaderLinkerScript.h
> include/lld/ReaderWriter/Simple.h
> include/lld/ReaderWriter/Writer.h
> lib/Core/CMakeLists.txt
> lib/Core/LinkerContext.cpp
> lib/Core/TargetInfo.cpp
> lib/Core/Resolver.cpp
> lib/Core/SymbolTable.cpp
> lib/Driver/CoreDriver.cpp
> lib/Driver/DarwinLdDriver.cpp
> lib/Driver/Driver.cpp
> lib/Driver/GnuLdDriver.cpp
> lib/Driver/WinLinkDriver.cpp
> lib/ReaderWriter/CMakeLists.txt
> lib/ReaderWriter/CoreLinkerContext.cpp
> lib/ReaderWriter/CoreTargetInfo.cpp
> lib/ReaderWriter/ELF/Atoms.h
> lib/ReaderWriter/ELF/CMakeLists.txt
> lib/ReaderWriter/ELF/Chunk.h
> lib/ReaderWriter/ELF/DefaultLayout.h
> lib/ReaderWriter/ELF/DefaultTargetHandler.h
> lib/ReaderWriter/ELF/DynamicFile.h
> lib/ReaderWriter/ELF/DynamicLibraryWriter.h
> lib/ReaderWriter/ELF/ELFLinkerContext.cpp
> lib/ReaderWriter/ELF/ELFTargetInfo.cpp
> lib/ReaderWriter/ELF/ExecutableAtoms.h
> lib/ReaderWriter/ELF/ExecutableWriter.h
> lib/ReaderWriter/ELF/File.h
> lib/ReaderWriter/ELF/HeaderChunks.h
> lib/ReaderWriter/ELF/Hexagon/CMakeLists.txt
> lib/ReaderWriter/ELF/Hexagon/HexagonExecutableAtoms.h
> lib/ReaderWriter/ELF/Hexagon/HexagonLinkerContext.cpp
> lib/ReaderWriter/ELF/Hexagon/HexagonTargetInfo.cpp
> lib/ReaderWriter/ELF/Hexagon/HexagonLinkerContext.h
> lib/ReaderWriter/ELF/Hexagon/HexagonTargetInfo.h
> lib/ReaderWriter/ELF/Hexagon/HexagonRelocationHandler.cpp
> lib/ReaderWriter/ELF/Hexagon/HexagonRelocationHandler.h
> lib/ReaderWriter/ELF/Hexagon/HexagonSectionChunks.h
> lib/ReaderWriter/ELF/Hexagon/HexagonTarget.h
> lib/ReaderWriter/ELF/Hexagon/HexagonTargetHandler.cpp
> lib/ReaderWriter/ELF/Hexagon/HexagonTargetHandler.h
> lib/ReaderWriter/ELF/OutputELFWriter.h
> lib/ReaderWriter/ELF/PPC/CMakeLists.txt
> lib/ReaderWriter/ELF/PPC/PPCLinkerContext.cpp
> lib/ReaderWriter/ELF/PPC/PPCTargetInfo.cpp
> lib/ReaderWriter/ELF/PPC/PPCLinkerContext.h
> lib/ReaderWriter/ELF/PPC/PPCTargetInfo.h
> lib/ReaderWriter/ELF/PPC/PPCTarget.h
> lib/ReaderWriter/ELF/PPC/PPCTargetHandler.cpp
> lib/ReaderWriter/ELF/PPC/PPCTargetHandler.h
> lib/ReaderWriter/ELF/Reader.cpp
> lib/ReaderWriter/ELF/SectionChunks.h
> lib/ReaderWriter/ELF/SegmentChunks.h
> lib/ReaderWriter/ELF/TargetHandler.h
> lib/ReaderWriter/ELF/TargetLayout.h
> lib/ReaderWriter/ELF/Writer.cpp
> lib/ReaderWriter/ELF/X86/CMakeLists.txt
> lib/ReaderWriter/ELF/X86/X86LinkerContext.cpp
> lib/ReaderWriter/ELF/X86/X86TargetInfo.cpp
> lib/ReaderWriter/ELF/X86/X86LinkerContext.h
> lib/ReaderWriter/ELF/X86/X86TargetInfo.h
> lib/ReaderWriter/ELF/X86/X86Target.h
> lib/ReaderWriter/ELF/X86/X86TargetHandler.cpp
> lib/ReaderWriter/ELF/X86/X86TargetHandler.h
> lib/ReaderWriter/ELF/X86_64/CMakeLists.txt
> lib/ReaderWriter/ELF/X86_64/X86_64LinkerContext.cpp
> lib/ReaderWriter/ELF/X86_64/X86_64TargetInfo.cpp
> lib/ReaderWriter/ELF/X86_64/X86_64LinkerContext.h
> lib/ReaderWriter/ELF/X86_64/X86_64TargetInfo.h
> lib/ReaderWriter/ELF/X86_64/X86_64RelocationHandler.cpp
> lib/ReaderWriter/ELF/X86_64/X86_64RelocationHandler.h
> lib/ReaderWriter/ELF/X86_64/X86_64Target.h
> lib/ReaderWriter/ELF/X86_64/X86_64TargetHandler.cpp
> lib/ReaderWriter/ELF/X86_64/X86_64TargetHandler.h
> lib/ReaderWriter/MachO/CMakeLists.txt
> lib/ReaderWriter/MachO/ExecutableAtoms.hpp
> lib/ReaderWriter/MachO/MachOLinkerContext.cpp
> lib/ReaderWriter/MachO/MachOTargetInfo.cpp
> lib/ReaderWriter/MachO/ReferenceKinds.cpp
> lib/ReaderWriter/MachO/ReferenceKinds.h
> lib/ReaderWriter/MachO/StubsPass.hpp
> lib/ReaderWriter/MachO/WriterMachO.cpp
> lib/ReaderWriter/Native/ReaderNative.cpp
> lib/ReaderWriter/Native/WriterNative.cpp
> lib/ReaderWriter/PECOFF/CMakeLists.txt
> lib/ReaderWriter/PECOFF/PECOFFLinkerContext.cpp
> lib/ReaderWriter/PECOFF/PECOFFTargetInfo.cpp
> lib/ReaderWriter/PECOFF/ReaderCOFF.cpp
> lib/ReaderWriter/PECOFF/ReaderImportHeader.cpp
> lib/ReaderWriter/PECOFF/ReaderImportHeader.h
> lib/ReaderWriter/PECOFF/WriterPECOFF.cpp
> lib/ReaderWriter/ReaderArchive.cpp
> lib/ReaderWriter/ReaderLinkerScript.cpp
> lib/ReaderWriter/YAML/ReaderWriterYAML.cpp
> unittests/DriverTests/DarwinLdDriverTest.cpp
> unittests/DriverTests/DriverTest.h
> unittests/DriverTests/GnuLdDriverTest.cpp
> unittests/DriverTests/WinLinkDriverTest.cpp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130806/b5aa7413/attachment.html>
More information about the llvm-commits
mailing list