<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>LGTM.</div><div><br></div><div>My only comment is that it would have been nice to discuss the name before you did all this work. For instance, I was wondering if LinkingContext would be better than LinkerContext. I do like have the variables named just “context”.</div><div><br></div><div>-Nick</div><br><div><div>On Aug 6, 2013, at 12:49 PM, Rui Ueyama <<a href="mailto:ruiu@google.com">ruiu@google.com</a>> wrote:</div><blockquote type="cite"><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div dir="ltr">So this is a patch to rename the class as we discussed recently. This patch virtually touches all the file and will conflict with any patch. I want to check this in as soon as possible to minimize the possibility of conflicts. I'd appreciate if you could review this quickly. Thanks!</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Aug 6, 2013 at 12:44 PM, Rui Ueyama<span class="Apple-converted-space"> </span><span dir="ltr"><<a href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;">Hi kledzik, shankarke, Bigcheese,<br><br>Also change some local variable names: "ti" -> "ctx" and<br>"_targetInfo" -> "_context".<br><br><a href="http://llvm-reviews.chandlerc.com/D1301" target="_blank">http://llvm-reviews.chandlerc.com/D1301</a><br><br>Files:<br> <span class="Apple-converted-space"> </span>docs/Driver.rst<br> <span class="Apple-converted-space"> </span>include/lld/Core/ArchiveLibraryFile.h<br> <span class="Apple-converted-space"> </span>include/lld/Core/File.h<br> <span class="Apple-converted-space"> </span>include/lld/Core/LinkerContext.h<br> <span class="Apple-converted-space"> </span>include/lld/Core/TargetInfo.h<br> <span class="Apple-converted-space"> </span>include/lld/Core/Resolver.h<br> <span class="Apple-converted-space"> </span>include/lld/Core/SymbolTable.h<br> <span class="Apple-converted-space"> </span>include/lld/Driver/Driver.h<br> <span class="Apple-converted-space"> </span>include/lld/ReaderWriter/CoreLinkerContext.h<br> <span class="Apple-converted-space"> </span>include/lld/ReaderWriter/CoreTargetInfo.h<br> <span class="Apple-converted-space"> </span>include/lld/ReaderWriter/ELFLinkerContext.h<br> <span class="Apple-converted-space"> </span>include/lld/ReaderWriter/ELFTargetInfo.h<br> <span class="Apple-converted-space"> </span>include/lld/ReaderWriter/MachOLinkerContext.h<br> <span class="Apple-converted-space"> </span>include/lld/ReaderWriter/MachOTargetInfo.h<br> <span class="Apple-converted-space"> </span>include/lld/ReaderWriter/PECOFFLinkerContext.h<br> <span class="Apple-converted-space"> </span>include/lld/ReaderWriter/PECOFFTargetInfo.h<br> <span class="Apple-converted-space"> </span>include/lld/ReaderWriter/Reader.h<br> <span class="Apple-converted-space"> </span>include/lld/ReaderWriter/ReaderArchive.h<br> <span class="Apple-converted-space"> </span>include/lld/ReaderWriter/ReaderLinkerScript.h<br> <span class="Apple-converted-space"> </span>include/lld/ReaderWriter/Simple.h<br> <span class="Apple-converted-space"> </span>include/lld/ReaderWriter/Writer.h<br> <span class="Apple-converted-space"> </span>lib/Core/CMakeLists.txt<br> <span class="Apple-converted-space"> </span>lib/Core/LinkerContext.cpp<br> <span class="Apple-converted-space"> </span>lib/Core/TargetInfo.cpp<br> <span class="Apple-converted-space"> </span>lib/Core/Resolver.cpp<br> <span class="Apple-converted-space"> </span>lib/Core/SymbolTable.cpp<br> <span class="Apple-converted-space"> </span>lib/Driver/CoreDriver.cpp<br> <span class="Apple-converted-space"> </span>lib/Driver/DarwinLdDriver.cpp<br> <span class="Apple-converted-space"> </span>lib/Driver/Driver.cpp<br> <span class="Apple-converted-space"> </span>lib/Driver/GnuLdDriver.cpp<br> <span class="Apple-converted-space"> </span>lib/Driver/WinLinkDriver.cpp<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/CMakeLists.txt<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/CoreLinkerContext.cpp<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/CoreTargetInfo.cpp<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/Atoms.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/CMakeLists.txt<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/Chunk.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/DefaultLayout.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/DefaultTargetHandler.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/DynamicFile.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/DynamicLibraryWriter.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/ELFLinkerContext.cpp<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/ELFTargetInfo.cpp<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/ExecutableAtoms.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/ExecutableWriter.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/File.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/HeaderChunks.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/Hexagon/CMakeLists.txt<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/Hexagon/HexagonExecutableAtoms.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/Hexagon/HexagonLinkerContext.cpp<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/Hexagon/HexagonTargetInfo.cpp<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/Hexagon/HexagonLinkerContext.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/Hexagon/HexagonTargetInfo.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/Hexagon/HexagonRelocationHandler.cpp<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/Hexagon/HexagonRelocationHandler.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/Hexagon/HexagonSectionChunks.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/Hexagon/HexagonTarget.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/Hexagon/HexagonTargetHandler.cpp<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/Hexagon/HexagonTargetHandler.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/OutputELFWriter.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/PPC/CMakeLists.txt<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/PPC/PPCLinkerContext.cpp<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/PPC/PPCTargetInfo.cpp<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/PPC/PPCLinkerContext.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/PPC/PPCTargetInfo.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/PPC/PPCTarget.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/PPC/PPCTargetHandler.cpp<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/PPC/PPCTargetHandler.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/Reader.cpp<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/SectionChunks.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/SegmentChunks.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/TargetHandler.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/TargetLayout.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/Writer.cpp<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/X86/CMakeLists.txt<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/X86/X86LinkerContext.cpp<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/X86/X86TargetInfo.cpp<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/X86/X86LinkerContext.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/X86/X86TargetInfo.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/X86/X86Target.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/X86/X86TargetHandler.cpp<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/X86/X86TargetHandler.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/X86_64/CMakeLists.txt<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/X86_64/X86_64LinkerContext.cpp<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/X86_64/X86_64TargetInfo.cpp<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/X86_64/X86_64LinkerContext.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/X86_64/X86_64TargetInfo.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/X86_64/X86_64RelocationHandler.cpp<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/X86_64/X86_64RelocationHandler.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/X86_64/X86_64Target.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/X86_64/X86_64TargetHandler.cpp<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ELF/X86_64/X86_64TargetHandler.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/MachO/CMakeLists.txt<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/MachO/ExecutableAtoms.hpp<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/MachO/MachOLinkerContext.cpp<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/MachO/MachOTargetInfo.cpp<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/MachO/ReferenceKinds.cpp<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/MachO/ReferenceKinds.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/MachO/StubsPass.hpp<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/MachO/WriterMachO.cpp<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/Native/ReaderNative.cpp<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/Native/WriterNative.cpp<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/PECOFF/CMakeLists.txt<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/PECOFF/PECOFFLinkerContext.cpp<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/PECOFF/PECOFFTargetInfo.cpp<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/PECOFF/ReaderCOFF.cpp<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/PECOFF/ReaderImportHeader.cpp<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/PECOFF/ReaderImportHeader.h<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/PECOFF/WriterPECOFF.cpp<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ReaderArchive.cpp<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/ReaderLinkerScript.cpp<br> <span class="Apple-converted-space"> </span>lib/ReaderWriter/YAML/ReaderWriterYAML.cpp<br> <span class="Apple-converted-space"> </span>unittests/DriverTests/DarwinLdDriverTest.cpp<br> <span class="Apple-converted-space"> </span>unittests/DriverTests/DriverTest.h<br> <span class="Apple-converted-space"> </span>unittests/DriverTests/GnuLdDriverTest.cpp<br> <span class="Apple-converted-space"> </span>unittests/DriverTests/WinLinkDriverTest.cpp</blockquote></div></div></div></blockquote></div><br></body></html>