I think that looks reasonable to me. isalnum would be slightly sketchy in the general code-base (it's locale-dependent), but we have more control over our tests and FileCheck is already using it. http://llvm-reviews.chandlerc.com/D1271