[llvm] r187666 - [ARMv8] Add an assembler warning for the deprecated 'setend' instruction.

Joey Gouly joey.gouly at arm.com
Fri Aug 2 12:18:12 PDT 2013


Author: joey
Date: Fri Aug  2 14:18:12 2013
New Revision: 187666

URL: http://llvm.org/viewvc/llvm-project?rev=187666&view=rev
Log:
[ARMv8] Add an assembler warning for the deprecated 'setend' instruction.

Added:
    llvm/trunk/test/MC/ARM/deprecated-v8.s
Modified:
    llvm/trunk/lib/Target/ARM/AsmParser/ARMAsmParser.cpp

Modified: llvm/trunk/lib/Target/ARM/AsmParser/ARMAsmParser.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/AsmParser/ARMAsmParser.cpp?rev=187666&r1=187665&r2=187666&view=diff
==============================================================================
--- llvm/trunk/lib/Target/ARM/AsmParser/ARMAsmParser.cpp (original)
+++ llvm/trunk/lib/Target/ARM/AsmParser/ARMAsmParser.cpp Fri Aug  2 14:18:12 2013
@@ -229,6 +229,7 @@ class ARMAsmParser : public MCTargetAsmP
                               SmallVectorImpl<MCParsedAsmOperand*> &Operands);
   bool shouldOmitPredicateOperand(StringRef Mnemonic,
                               SmallVectorImpl<MCParsedAsmOperand*> &Operands);
+  bool isDeprecated(MCInst &Inst, StringRef &Info);
 
 public:
   enum ARMMatchResultTy {
@@ -4876,6 +4877,13 @@ bool ARMAsmParser::shouldOmitPredicateOp
   return false;
 }
 
+bool ARMAsmParser::isDeprecated(MCInst &Inst, StringRef &Info) {
+  if (hasV8Ops() && Inst.getOpcode() == ARM::SETEND) {
+    Info = "armv8";
+    return true;
+  }
+}
+
 static bool isDataTypeToken(StringRef Tok) {
   return Tok == ".8" || Tok == ".16" || Tok == ".32" || Tok == ".64" ||
     Tok == ".i8" || Tok == ".i16" || Tok == ".i32" || Tok == ".i64" ||
@@ -5376,6 +5384,10 @@ validateInstruction(MCInst &Inst,
   }
   }
 
+  StringRef DepInfo;
+  if (isDeprecated(Inst, DepInfo))
+    Warning(Loc, "deprecated on " + DepInfo);
+
   return false;
 }
 

Added: llvm/trunk/test/MC/ARM/deprecated-v8.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/ARM/deprecated-v8.s?rev=187666&view=auto
==============================================================================
--- llvm/trunk/test/MC/ARM/deprecated-v8.s (added)
+++ llvm/trunk/test/MC/ARM/deprecated-v8.s Fri Aug  2 14:18:12 2013
@@ -0,0 +1,3 @@
+@ RUN: llvm-mc -triple armv8 -show-encoding < %s 2>&1 | FileCheck %s
+setend be
+@ CHECK: warning: deprecated on armv8





More information about the llvm-commits mailing list