[patch] FlattenCFG (refactoring)

[Andrew Trick]

On Aug 1, 2013, at 6:42 PM, Ye, Mei <Mei.Ye at amd.com> wrote:

> Attached patch re-factor the code out from SimplifyCFG.   Please review.  Thanks a lot.
>  
> -Mei
> <odc_refactor>

Thanks for making those changes. I’m ok with this patch as-is. A couple questions though:

I thought that FlattenCFGPass would be a target pass, AMDGPUFlattenCFG. Other targets could add their own equivalent pass but may choose to interleave other target-specific CFG transforms. Do you foresee adding more CFG transforms for AMD? If so, you may want to start with this as a target pass so you can extend it incrementally without being forced to checkin to target-independent code.

This is just curiosity, but does this patch measurably increase compile time? If so I’m curious if you can plugin a target-specific inlining pass. That could improve your compile time in general.

-Andy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130802/d620de8d/attachment.html>