[patch] FlattenCFG (refactoring)

Christian König deathsimple at vodafone.de
Thu Aug 1 23:52:05 PDT 2013


> ===================================================================
> --- lib/Target/R600/AMDGPUTargetMachine.cpp    (revision 187503)
> +++ lib/Target/R600/AMDGPUTargetMachine.cpp    (working copy)
> @@ -91,7 +91,7 @@
>    AMDGPUTargetMachine &getAMDGPUTargetMachine() const {
>      return getTM<AMDGPUTargetMachine>();
>    }
> -
> +  virtual void addIRPasses();
>    virtual bool addPreISel();
>    virtual bool addInstSelector();
>    virtual bool addPreRegAlloc();
> @@ -117,9 +117,15 @@
>    PM.add(createAMDGPUTargetTransformInfoPass(this));
>  }
>
> +void
> +AMDGPUPassConfig::addIRPasses() {
> +  TargetPassConfig::addIRPasses();
> +}

That looks like an unnecessary change to me, some kind of leftover?

Apart from that the patch LGTM on first glance, but I haven't read it 
completely.

Christian.

Am 02.08.2013 03:42, schrieb Ye, Mei:
>
> Attached patch re-factor the code out from SimplifyCFG.   Please 
> review.  Thanks a lot.
>
> -Mei
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list