[llvm] r187325 - fixed compilation issue

[Craig Topper]

I already changed this code because I didn't like that we were using
sprintf like this. Normally for such case we use things like
std::string/SmallString and stream into it and then convert it. But in this
case its more friendly to the user to send the message to stderr which we
can just stream to and put a more generic message on the llvm_unreachable
that doens't need anything concatenated.


On Mon, Jul 29, 2013 at 11:51 AM, Bill Wendling <wendling at apple.com> wrote:

> On Jul 28, 2013, at 1:45 AM, Elena Demikhovsky <
> elena.demikhovsky at intel.com> wrote:
>
> > Author: delena
> > Date: Sun Jul 28 03:45:12 2013
> > New Revision: 187325
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=187325&view=rev
> > Log:
> > fixed compilation issue
> >
> > Modified:
> >    llvm/trunk/utils/TableGen/X86RecognizableInstr.cpp
> >
> > Modified: llvm/trunk/utils/TableGen/X86RecognizableInstr.cpp
> > URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/X86RecognizableInstr.cpp?rev=187325&r1=187324&r2=187325&view=diff
> >
> ==============================================================================
> > --- llvm/trunk/utils/TableGen/X86RecognizableInstr.cpp (original)
> > +++ llvm/trunk/utils/TableGen/X86RecognizableInstr.cpp Sun Jul 28
> 03:45:12 2013
> > @@ -19,6 +19,7 @@
> > #include "X86ModRMFilters.h"
> > #include "llvm/Support/ErrorHandling.h"
> > #include <string>
> > +#include <stdio.h>
> >
> Could you use <cstdio> instead?
>
> -bw
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



-- 
~Craig
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130729/2a89c7ff/attachment.html>