<div dir="ltr">I already changed this code because I didn't like that we were using sprintf like this. Normally for such case we use things like std::string/SmallString and stream into it and then convert it. But in this case its more friendly to the user to send the message to stderr which we can just stream to and put a more generic message on the llvm_unreachable that doens't need anything concatenated.</div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jul 29, 2013 at 11:51 AM, Bill Wendling <span dir="ltr"><<a href="mailto:wendling@apple.com" target="_blank">wendling@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Jul 28, 2013, at 1:45 AM, Elena Demikhovsky <<a href="mailto:elena.demikhovsky@intel.com">elena.demikhovsky@intel.com</a>> wrote:<br>

<br>
> Author: delena<br>
> Date: Sun Jul 28 03:45:12 2013<br>
> New Revision: 187325<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=187325&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=187325&view=rev</a><br>
> Log:<br>
> fixed compilation issue<br>
><br>
> Modified:<br>
>    llvm/trunk/utils/TableGen/X86RecognizableInstr.cpp<br>
><br>
> Modified: llvm/trunk/utils/TableGen/X86RecognizableInstr.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/X86RecognizableInstr.cpp?rev=187325&r1=187324&r2=187325&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/X86RecognizableInstr.cpp?rev=187325&r1=187324&r2=187325&view=diff</a><br>

> ==============================================================================<br>
> --- llvm/trunk/utils/TableGen/X86RecognizableInstr.cpp (original)<br>
> +++ llvm/trunk/utils/TableGen/X86RecognizableInstr.cpp Sun Jul 28 03:45:12 2013<br>
> @@ -19,6 +19,7 @@<br>
> #include "X86ModRMFilters.h"<br>
> #include "llvm/Support/ErrorHandling.h"<br>
> #include <string><br>
> +#include <stdio.h><br>
><br>
</div>Could you use <cstdio> instead?<br>
<span class="HOEnZb"><font color="#888888"><br>
-bw<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>~Craig
</div>