[PATCH] Usability improvements for Intel X86 disassembly (llvm)

Richard Mitton richard at codersnotes.com
Mon Jul 29 12:18:31 PDT 2013


... ping?

I'd love some feedback on this as it's my first LLVM patch. We'd like to 
use it for LLDB.

Richard Mitton
richard at codersnotes.com

On 07/26/2013 11:58 AM, Richard Mitton wrote:
> richard.mitton added you to the CC list for the revision "Usability improvements for Intel X86 disassembly (llvm)".
>
> This patch adds options for various usability issues when using the Intel X86 disassembler.
>
> The following changes were made to bring Intel syntax in line with AT&T:
> - immediate values can be selected to appear as either hex or decimal
> - register names and keywords lowercased to be consistent with both att syntax and general sanity.
> - annotated markup is supported in the disassembly (same as att)
>
> In addition the following new changes are implemented:
> - fixed a bug where MOV16016a would disassembly wrongly for Intel.
> - added a switch for the user to select which style of hex constants they would prefer (c/pascal/asm style)
>
>
> http://llvm-reviews.chandlerc.com/D1221
>
> Files:
>    test/MC/Disassembler/X86/intel-syntax.txt
>    test/CodeGen/X86/lea-2.ll
>    test/CodeGen/X86/fp_constant_op.ll
>    test/CodeGen/X86/store_op_load_fold2.ll
>    test/CodeGen/X86/shift-coalesce.ll
>    test/CodeGen/X86/fast-cc-merge-stack-adj.ll
>    test/CodeGen/X86/fast-cc-pass-in-regs.ll
>    lib/MC/MCInstPrinter.cpp
>    lib/Target/X86/X86InstrArithmetic.td
>    lib/Target/X86/X86InstrSSE.td
>    lib/Target/X86/X86InstrShiftRotate.td
>    lib/Target/X86/InstPrinter/X86IntelInstPrinter.cpp
>    lib/Target/X86/InstPrinter/X86IntelInstPrinter.h
>    lib/Target/X86/InstPrinter/X86ATTInstPrinter.cpp
>    lib/Target/X86/X86InstrFPStack.td
>    lib/Target/X86/X86InstrSVM.td
>    lib/Target/X86/X86InstrInfo.td
>    lib/Target/X86/X86InstrSystem.td
>    include/llvm/MC/MCInstPrinter.h
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130729/9bfee625/attachment.html>


More information about the llvm-commits mailing list