<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">... ping?<br>
<br>
I'd love some feedback on this as it's my first LLVM patch. We'd
like to use it for LLDB.<br>
<br>
<pre class="moz-signature" cols="72">Richard Mitton
<a class="moz-txt-link-abbreviated" href="mailto:richard@codersnotes.com">richard@codersnotes.com</a></pre>
On 07/26/2013 11:58 AM, Richard Mitton wrote:<br>
</div>
<blockquote
cite="mid:c1b95406f436622030fe83eb32abd369@llvm-reviews.chandlerc.com"
type="cite">
<pre wrap="">richard.mitton added you to the CC list for the revision "Usability improvements for Intel X86 disassembly (llvm)".
This patch adds options for various usability issues when using the Intel X86 disassembler.
The following changes were made to bring Intel syntax in line with AT&T:
- immediate values can be selected to appear as either hex or decimal
- register names and keywords lowercased to be consistent with both att syntax and general sanity.
- annotated markup is supported in the disassembly (same as att)
In addition the following new changes are implemented:
- fixed a bug where MOV16016a would disassembly wrongly for Intel.
- added a switch for the user to select which style of hex constants they would prefer (c/pascal/asm style)
<a class="moz-txt-link-freetext" href="http://llvm-reviews.chandlerc.com/D1221">http://llvm-reviews.chandlerc.com/D1221</a>
Files:
test/MC/Disassembler/X86/intel-syntax.txt
test/CodeGen/X86/lea-2.ll
test/CodeGen/X86/fp_constant_op.ll
test/CodeGen/X86/store_op_load_fold2.ll
test/CodeGen/X86/shift-coalesce.ll
test/CodeGen/X86/fast-cc-merge-stack-adj.ll
test/CodeGen/X86/fast-cc-pass-in-regs.ll
lib/MC/MCInstPrinter.cpp
lib/Target/X86/X86InstrArithmetic.td
lib/Target/X86/X86InstrSSE.td
lib/Target/X86/X86InstrShiftRotate.td
lib/Target/X86/InstPrinter/X86IntelInstPrinter.cpp
lib/Target/X86/InstPrinter/X86IntelInstPrinter.h
lib/Target/X86/InstPrinter/X86ATTInstPrinter.cpp
lib/Target/X86/X86InstrFPStack.td
lib/Target/X86/X86InstrSVM.td
lib/Target/X86/X86InstrInfo.td
lib/Target/X86/X86InstrSystem.td
include/llvm/MC/MCInstPrinter.h
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
llvm-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a>
</pre>
</blockquote>
<br>
</body>
</html>