[patch] simplifyCFG for review

[Christian König]

Well, it's definitely not your fault. Cause you have followed the 
official code review process quite well 
(http://llvm.org/docs/DeveloperPolicy.html#code-reviews).

On the other hand you have probably targeted a bit to much by directly 
going into the direction of adding the passes to very common (e.g. 
target independent) code. For a start it would have probably been better 
to add the passes to the R600 backend alone and let them age a bit there 
while doing the necessary refactoring of the existing SimplifyCFG code.

But anyway the damage is done, and we new have only two options: Fix it 
inplace or rip it out again and fix it then, I'm fine with either.

Christian.

Am 29.07.2013 04:52, schrieb Ye, Mei:
>
> It also depends on review turn-around time.  I have to say that the 
> review process is not clearly defined here.  And it is the most 
> lengthy review compared to other open sources.
>
>
> -Mei
>
> *From:*Chandler Carruth [mailto:chandlerc at google.com]
> *Sent:* Sunday, July 28, 2013 5:26 PM
> *To:* Ye, Mei
> *Cc:* Andrew Trick; Matt Arsenault; Evan Cheng; llvm commits; Koenig, 
> Christian
> *Subject:* Re: [patch] simplifyCFG for review
>
> On Sun, Jul 28, 2013 at 3:10 PM, Ye, Mei <Mei.Ye at amd.com 
> <mailto:Mei.Ye at amd.com>> wrote:
>
> I will re-factor the code following your suggestion.  If the check-in 
> process can’t be finished next week,  please allow some delay since my 
> sabbatical is coming.
>
>
> FWIW, if you can't finish the refactoring in a reasonably short period 
> of time, it might be more appropriate to pull this out and refactor it 
> locally when you have time, and resubmit it.
>
> Note, I don't have a problem with refactoring it in-tree, just don't 
> want you to feel pressured to finish it in a short timeframe, and 
> don't want others to be confused by the half-refactored state of 
> things over a long period of time.
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130729/fed98d18/attachment.html>