<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Well, it's definitely not your fault.
Cause you have followed the official code review process quite
well (<a class="moz-txt-link-freetext" href="http://llvm.org/docs/DeveloperPolicy.html#code-reviews">http://llvm.org/docs/DeveloperPolicy.html#code-reviews</a>).<br>
<br>
On the other hand you have probably targeted a bit to much by
directly going into the direction of adding the passes to very
common (e.g. target independent) code. For a start it would have
probably been better to add the passes to the R600 backend alone
and let them age a bit there while doing the necessary refactoring
of the existing SimplifyCFG code.<br>
<br>
But anyway the damage is done, and we new have only two options:
Fix it inplace or rip it out again and fix it then, I'm fine with
either.<br>
<br>
Christian.<br>
<br>
Am 29.07.2013 04:52, schrieb Ye, Mei:<br>
</div>
<blockquote
cite="mid:87C5754BF7FCA043BFEC66764261A44C046D2ED1@sausexdag02.amd.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<meta name="Generator" content="Microsoft Word 12 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">It
also depends on review turn-around time. I have to say that
the review process is not clearly defined here. And it is
the most lengthy review compared to other open sources.<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p><br>
</o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">-Mei<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<div style="border:none;border-top:solid #B5C4DF
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">
Chandler Carruth [<a class="moz-txt-link-freetext" href="mailto:chandlerc@google.com">mailto:chandlerc@google.com</a>]
<br>
<b>Sent:</b> Sunday, July 28, 2013 5:26 PM<br>
<b>To:</b> Ye, Mei<br>
<b>Cc:</b> Andrew Trick; Matt Arsenault; Evan Cheng; llvm
commits; Koenig, Christian<br>
<b>Subject:</b> Re: [patch] simplifyCFG for review<o:p></o:p></span></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">On Sun, Jul 28, 2013 at 3:10 PM, Ye,
Mei <<a moz-do-not-send="true"
href="mailto:Mei.Ye@amd.com" target="_blank">Mei.Ye@amd.com</a>>
wrote:<o:p></o:p></p>
<p class="MsoNormal">I will re-factor the code following
your suggestion. If the check-in process can’t be
finished next week, please allow some delay since my
sabbatical is coming.<o:p></o:p></p>
</div>
<p class="MsoNormal"><br>
FWIW, if you can't finish the refactoring in a reasonably
short period of time, it might be more appropriate to pull
this out and refactor it locally when you have time, and
resubmit it.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Note, I don't have a problem with
refactoring it in-tree, just don't want you to feel
pressured to finish it in a short timeframe, and don't
want others to be confused by the half-refactored state of
things over a long period of time.<o:p></o:p></p>
</div>
</div>
</div>
</blockquote>
<br>
</body>
</html>