[llvm] r186588 - Windows/Path.inc: Introduce file_type::character_file and file_type::fifo_file in sys::fs::getStatus(HANDLE).

NAKAMURA Takumi geek4civic at gmail.com
Thu Jul 18 18:11:33 PDT 2013


Thanks, Rafael.

2013/7/19 Aaron Ballman <aaron at aaronballman.com>:
> I think this patch is preferable.
>
> ~Aaron
>
> On Thu, Jul 18, 2013 at 2:20 PM, Rafael EspĂ­ndola
> <rafael.espindola at gmail.com> wrote:
>> Thanks!
>>
>>> +  switch (::GetFileType(FileHandle)) {
>>> +  default:
>>> +  case FILE_TYPE_UNKNOWN:
>>
>> Is this the correct handling of default and  FILE_TYPE_UNKNOWN? I was
>> thinking of something like the attached patch. What do you think?
>>
>> Cheers,
>> Rafael
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>




More information about the llvm-commits mailing list