[llvm] r186588 - Windows/Path.inc: Introduce file_type::character_file and file_type::fifo_file in sys::fs::getStatus(HANDLE).

Aaron Ballman aaron at aaronballman.com
Thu Jul 18 11:25:31 PDT 2013


I think this patch is preferable.

~Aaron

On Thu, Jul 18, 2013 at 2:20 PM, Rafael EspĂ­ndola
<rafael.espindola at gmail.com> wrote:
> Thanks!
>
>> +  switch (::GetFileType(FileHandle)) {
>> +  default:
>> +  case FILE_TYPE_UNKNOWN:
>
> Is this the correct handling of default and  FILE_TYPE_UNKNOWN? I was
> thinking of something like the attached patch. What do you think?
>
> Cheers,
> Rafael
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>




More information about the llvm-commits mailing list