[lld] r185657 - Don't pass llvm::errs() all over the place. Diagnostics always go to stderr.

[Craig Topper]

Don't the majority of clang's diagnostics go through the DiagnosticsEngine
which is itself controllable as to where it goes?


On Thu, Jul 4, 2013 at 9:43 PM, Rafael Espíndola <rafael.espindola at gmail.com
> wrote:

> On 4 July 2013 21:47, Nick Kledzik <kledzik at apple.com> wrote:
> > This seems worse off.  If lld was strictly a command line tool, I can
> see just just writing to stderr everywhere would be fine.  But we want lld
> to be a library too.  And the clients of the library will want better
> control over where diagnostics go.  In addition, if multiple things are
> being linked in parallel, the client could create a separate ostream for
> each parallel instance.  By forcing all instances to use the same (stderr)
> stream, the errors will be intermixed.
>
> It is a library, just like llvm and clang. Those are valid uses, but
> until we actually have someone using them, we should do like llvm and
> clang and have the simpler interface. I did grep llvm and clang and
> using llvm::errs() is by far the more common pattern.
>
> > -Nick
>
> Cheers,
> Rafael
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



-- 
~Craig
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130704/b42139a5/attachment.html>