[llvm] r185676 - Remove use of asymmetric std::lower_bound comparator.

[Ahmed Bougacha]

On Thu, Jul 4, 2013 at 4:53 PM, Chandler Carruth <chandlerc at google.com>wrote:

>
> On Thu, Jul 4, 2013 at 4:20 PM, Ahmed Bougacha <ahmed.bougacha at gmail.com>wrote:
>
>> Author: ab
>> Date: Thu Jul  4 18:20:12 2013
>> New Revision: 185676
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=185676&view=rev
>> Log:
>> Remove use of asymmetric std::lower_bound comparator.
>>
>> VS 2008 doesn't like it when in debug mode.
>>
>
> There are a lot of very legitimate uses of asymmetric std::lower_bound
> comparators. I don't think we should criple our standard library support
> for a version of visual studio so old. Can we revert this and just ask
> people to use 2010 or newer?
>

We should, in fact I’m surprised we still claim to support 2008. If there
are no objections over the next few days, I can update the docs and revert
this.

On a related note, maybe it’s time to bring back the discussion about
switching to c++11, I believe the consensus of that old thread was
VS2010/g++-4.4/clang-3.1, over the 3.4 timeframe.

-- Ahmed
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130704/48e250c3/attachment.html>