[PATCH] Full support for dllexport/dllimport attributes

[Chandler Carruth]

On Thu, Jul 4, 2013 at 10:25 AM, Nico Rieck <nico.rieck at gmail.com> wrote:

> This patch series implements full support for dllexport/dllimport
> attributes


It's cool that you're working on this, but this patch is too big to review,
and can't even be sent to the right people to review. For example, you have
a significant change to Clang here, but sent it to the LLVM commits list
for review.

I would suggest:

1) Take all of the parsing, semantic analysis, and AST changes to Clang to
support these attributes and propose that as a single patch. No code
generation changes at all. Include most of the tests, etc. Get that
reviewed and committed.

2) Propose whatever LLVM support you need to code gen #1 correctly as an
LLVM-only patch. You should have comprehensive testing purely at the LLVM
layer.

3) Propose a patch that wires up the AST representation you added in #1 to
the LLVM IR representation in #2 to the Clang commits list.


This will make all three patches much easier to review, and will get the
right people involved at each step.

Thanks,
-Chandler
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130704/729c4533/attachment.html>