[patch] Use "set -o pipefail"

Rafael Espíndola rafael.espindola at gmail.com
Thu Jul 4 10:27:32 PDT 2013


Ping.

An updated patch is attached. Testing it found all the problems I just
fixed in existing tests. This patch updates both the internal and the
shell based testing system. It also changes 'not' so that 'not
a_crashing_program' return 0.

On 17 June 2013 10:16, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
> ping.
>
> On 12 June 2013 14:03, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
>> It is fairly inconvenient for tests like
>>
>> opt ... | FileCheck
>>
>> to pass if opt returns false after printing what FileCheck was looking
>> for. The attached patch adds "set -o pipefail" to the testscript that
>> lit creates.
>>
>> The patch adds a test that only passes if pipefail is enabled and
>> deletes to old tests:
>>
>> * test/CodeGen/X86/2007-05-07-InvokeSRet.ll: It had invalid IL.
>> * test/CodeGen/X86/2008-02-08-LoadFoldingBug.ll: it was running "grep
>> andpd | not grep esp" and passing because we were not printing any
>> andpd.
>>
>> I have tested that it works on linux and OS X. Is it OK if I also
>> update clang and lld tests?
>>
>> Cheers,
>> Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.patch
Type: application/octet-stream
Size: 3103 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130704/578b3ca4/attachment.obj>


More information about the llvm-commits mailing list