[PATCH] ARM: fix application of de morgan's law

[Bob Wilson]

On Jun 29, 2013, at 3:46 PM, David Majnemer <david.majnemer at gmail.com> wrote:

> CC'ing Bob Wilson
> 
> It seems like Bob introduced this check in r141370, he would probably best understand what was supposed to happen here.
> 
> -- 
> David Majnemer
> 
> 
> On Sat, Jun 29, 2013 at 3:19 PM, Tim Northover <t.p.northover at gmail.com> wrote:
> > This would inadvertently enable tail calls when they should not be.
> 
> > -  if (!EnableARMTailCalls && !Subtarget->supportsTailCall())
> > +  if (!EnableARMTailCalls || !Subtarget->supportsTailCall())
> 
> Are you sure this isn't the intended behaviour? It seems to come down
> to whether -arm-tail-calls means "do a tail call if you think it's
> safe" or "do a tail call even if you think it's unsafe". None of the
> surrounding documentation seems clear on the intent, but either
> interpretation could be useful for different people.

Look at r111050 for some history.  The “-arm-tail-calls” option should just be removed.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130629/52e7a670/attachment.html>