<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Jun 29, 2013, at 3:46 PM, David Majnemer <<a href="mailto:david.majnemer@gmail.com">david.majnemer@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div dir="ltr"><div>CC'ing Bob Wilson</div><div><br></div>It seems like Bob introduced this check in r141370, he would probably best understand what was supposed to happen here.<div><br></div><div>-- </div><div>David Majnemer</div></div></div></blockquote><blockquote type="cite"><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div class="gmail_extra"><br><br><div class="gmail_quote">On Sat, Jun 29, 2013 at 3:19 PM, Tim Northover<span class="Apple-converted-space"> </span><span dir="ltr"><<a href="mailto:t.p.northover@gmail.com" target="_blank">t.p.northover@gmail.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; position: static; z-index: auto;"><div class="im">> This would inadvertently enable tail calls when they should not be.<br><br></div><div class="im">> - if (!EnableARMTailCalls && !Subtarget->supportsTailCall())<br>> + if (!EnableARMTailCalls || !Subtarget->supportsTailCall())<br><br></div>Are you sure this isn't the intended behaviour? It seems to come down<br>to whether -arm-tail-calls means "do a tail call if you think it's<br>safe" or "do a tail call even if you think it's unsafe". None of the<br>surrounding documentation seems clear on the intent, but either<br>interpretation could be useful for different people.</blockquote></div></div></div></blockquote><br></div><div dir="auto">Look at r111050 for some history. The “-arm-tail-calls” option should just be removed.</div></body></html>