[llvm] r184217 - Add a GetUniqueID that will replace the uniqueID of PathV1.h.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Wed Jun 19 13:57:10 PDT 2013


> Regardless, as a function, shouldn't it at least be `getUniqueID` by our
> conventions (functions start with lowercase)?

Yes, my mistake. I will rename it once Aaron's patch is in.

> I think that the snake_case is
> because the library is modeled after one of the boost libs (which IIRC is
> slated for inclusion in C++14).

Which part? Both Path.h and FileSysetem.h? I guess once the V1 to V2
transition is complete the next cleanup in this area is then to split
the headers along the lines of what is slatted for c++14.

* A base header with a strict subset of the c++14 proposal, using the
names and semantics of the proposal so it can be implemented by just
forwarding to it in hosts with a c++14 library.

* A Utils or Extra header with LLVM specific utility functions using
llvm name style (getUniqueID) and desired semantics (not allowing
deleting /dev/null for example).

> -- Sean Silva

Cheers,
Rafael



More information about the llvm-commits mailing list