[llvm] r184271 - Remove unused parameter.

[David Blaikie]

On Jun 18, 2013 6:12 PM, "Sean Silva" <silvas at purdue.edu> wrote:
>
> Author: silvas
> Date: Tue Jun 18 20:10:11 2013
> New Revision: 184271
>
> URL: http://llvm.org/viewvc/llvm-project?rev=184271&view=rev
> Log:
> Remove unused parameter.
>
> Not sure why we weren't catching this with -Wunused-parameter...

Could you narrow down case test case and file a bug?

>
> Spotted by inspection.
>
> Modified:
>     llvm/trunk/tools/yaml2obj/yaml2elf.cpp
>
> Modified: llvm/trunk/tools/yaml2obj/yaml2elf.cpp
> URL:
http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/yaml2obj/yaml2elf.cpp?rev=184271&r1=184270&r2=184271&view=diff
>
==============================================================================
> --- llvm/trunk/tools/yaml2obj/yaml2elf.cpp (original)
> +++ llvm/trunk/tools/yaml2obj/yaml2elf.cpp Tue Jun 18 20:10:11 2013
> @@ -139,7 +139,6 @@ static void createStringTableSectionHead
>  template <class ELFT>
>  static void handleSymtabSectionHeader(
>      const ELFYAML::Section &Sec,
> -    const typename object::ELFObjectFile<ELFT>::Elf_Ehdr &Header,
>      typename object::ELFObjectFile<ELFT>::Elf_Shdr &SHeader,
>      StringTableBuilder &StrTab, ContiguousBlobAccumulator &CBA,
>      unsigned DotStrtabSecNo) {
> @@ -274,7 +273,7 @@ static int writeELF(raw_ostream &OS, con
>      SHeader.sh_entsize = 0;
>      // XXX: Really ugly right now. Need to put common state into a class.
>      if (Sec.Type == ELFYAML::ELF_SHT(SHT_SYMTAB))
> -      handleSymtabSectionHeader<ELFT>(Sec, Header, SHeader, DotStrTab,
CBA,
> +      handleSymtabSectionHeader<ELFT>(Sec, SHeader, DotStrTab, CBA,
>                                        DotStrtabSecNo);
>      SHeaders.push_back(SHeader);
>    }
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130618/bc75027a/attachment.html>