<p dir="ltr"><br>
On Jun 18, 2013 6:12 PM, "Sean Silva" <<a href="mailto:silvas@purdue.edu">silvas@purdue.edu</a>> wrote:<br>
><br>
> Author: silvas<br>
> Date: Tue Jun 18 20:10:11 2013<br>
> New Revision: 184271<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=184271&view=rev">http://llvm.org/viewvc/llvm-project?rev=184271&view=rev</a><br>
> Log:<br>
> Remove unused parameter.<br>
><br>
> Not sure why we weren't catching this with -Wunused-parameter...</p>
<p dir="ltr">Could you narrow down case test case and file a bug?</p>
<p dir="ltr">><br>
> Spotted by inspection.<br>
><br>
> Modified:<br>
> llvm/trunk/tools/yaml2obj/yaml2elf.cpp<br>
><br>
> Modified: llvm/trunk/tools/yaml2obj/yaml2elf.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/yaml2obj/yaml2elf.cpp?rev=184271&r1=184270&r2=184271&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/yaml2obj/yaml2elf.cpp?rev=184271&r1=184270&r2=184271&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/tools/yaml2obj/yaml2elf.cpp (original)<br>
> +++ llvm/trunk/tools/yaml2obj/yaml2elf.cpp Tue Jun 18 20:10:11 2013<br>
> @@ -139,7 +139,6 @@ static void createStringTableSectionHead<br>
> template <class ELFT><br>
> static void handleSymtabSectionHeader(<br>
> const ELFYAML::Section &Sec,<br>
> - const typename object::ELFObjectFile<ELFT>::Elf_Ehdr &Header,<br>
> typename object::ELFObjectFile<ELFT>::Elf_Shdr &SHeader,<br>
> StringTableBuilder &StrTab, ContiguousBlobAccumulator &CBA,<br>
> unsigned DotStrtabSecNo) {<br>
> @@ -274,7 +273,7 @@ static int writeELF(raw_ostream &OS, con<br>
> SHeader.sh_entsize = 0;<br>
> // XXX: Really ugly right now. Need to put common state into a class.<br>
> if (Sec.Type == ELFYAML::ELF_SHT(SHT_SYMTAB))<br>
> - handleSymtabSectionHeader<ELFT>(Sec, Header, SHeader, DotStrTab, CBA,<br>
> + handleSymtabSectionHeader<ELFT>(Sec, SHeader, DotStrTab, CBA,<br>
> DotStrtabSecNo);<br>
> SHeaders.push_back(SHeader);<br>
> }<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</p>