[PATCH] SelectionDAG: Fix incorrect condition checks in some cases of folding FADD/FMUL combinations

Nadav Rotem nrotem at apple.com
Fri Jun 14 09:17:25 PDT 2013


The FMA stuff looks okay (I did not review the order of operands carefully).  Your patch has some unrelated changes in it (windows/signals.inc .. )

Nadav

On Jun 14, 2013, at 9:12 AM, Stephen Lin <swlin at apple.com> wrote:

> Hi,
> 
> This is a fix for a bug noticed while in the process of implementing a different patch...a case was duplicated and order of operands was swapped, but some variable names were missed.
> 
> Fairly obvious fix, but it would be nice to have another set of eyes look over it to make sure that I didn’t miss anything else.
> 
> Also, some comments were slightly inaccurate so I fixed the comments to match what the code was doing. Alternatively, I could have fixed the code to match the comments, but it didn’t seem like there would be any benefit to doing so in this case.
> 
> <fix-unsafe-combine-fadd.patch>
> 
> Thanks,
> Stephen

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130614/6e0cc701/attachment.html>


More information about the llvm-commits mailing list