<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>The FMA stuff looks okay (I did not review the order of operands carefully). Your patch has some unrelated changes in it (windows/signals.inc .. )</div><div><br></div><div>Nadav</div><br><div><div>On Jun 14, 2013, at 9:12 AM, Stephen Lin <<a href="mailto:swlin@apple.com">swlin@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">Hi,<br><br>This is a fix for a bug noticed while in the process of implementing a different patch...a case was duplicated and order of operands was swapped, but some variable names were missed.<br><br>Fairly obvious fix, but it would be nice to have another set of eyes look over it to make sure that I didn’t miss anything else.<br><br>Also, some comments were slightly inaccurate so I fixed the comments to match what the code was doing. Alternatively, I could have fixed the code to match the comments, but it didn’t seem like there would be any benefit to doing so in this case.<br><br><span><fix-unsafe-combine-fadd.patch></span><br><br>Thanks,<br>Stephen</div></blockquote></div><br></body></html>