[PATCH] readobj: Dump PE/COFF optional records.

Rui Ueyama ruiu at google.com
Wed Jun 12 12:11:27 PDT 2013



================
Comment at: lib/Object/COFFObjectFile.cpp:478
@@ +477,3 @@
+      PE32Header = 0;
+    CurPtr += sizeof(pe32_header);
+  }
----------------
Rafael Ávila de Espíndola wrote:
> Is this correct in all variants? Shouldn't you use  Header->SizeOfOptionalHeader?
I should have. Fixed.


http://llvm-reviews.chandlerc.com/D939

BRANCH
  readobj

ARCANIST PROJECT
  llvm



More information about the llvm-commits mailing list