[PATCH] readobj: Dump PE/COFF optional records.
Rafael Ávila de Espíndola
rafael.espindola at gmail.com
Wed Jun 12 06:53:14 PDT 2013
OK with the small comment about SizeOfOptionalHeader.
================
Comment at: lib/Object/COFFObjectFile.cpp:478
@@ +477,3 @@
+ PE32Header = 0;
+ CurPtr += sizeof(pe32_header);
+ }
----------------
Is this correct in all variants? Shouldn't you use Header->SizeOfOptionalHeader?
http://llvm-reviews.chandlerc.com/D939
BRANCH
readobj
ARCANIST PROJECT
llvm
More information about the llvm-commits
mailing list