[llvm] r183551 - ARM FastISel integer sext/zext improvements

JF Bastien jfb at google.com
Fri Jun 7 17:53:03 PDT 2013


Fixed in r183601.


On Fri, Jun 7, 2013 at 5:46 PM, JF Bastien <jfb at google.com> wrote:

>
> This is generating a warning for me:
>>
>> /Users/sean/pg/llvm/touse/llvm/lib/Target/ARM/ARMFastISel.cpp:2664:12:
>> warning: unused variable 'DestBits' [-Wunused-variable]
>>   unsigned DestBits = DestVT.getSizeInBits();
>>            ^
>> 1 warning generated.
>>
>
> Sorry about that. The following diff should fix the issue (it's only used
> in the below asserts). OK to commit?
>
>
> diff --git a/lib/Target/ARM/ARMFastISel.cpp
> b/lib/Target/ARM/ARMFastISel.cpp
> index 16383bf..62bc782 100644
> --- a/lib/Target/ARM/ARMFastISel.cpp
> +++ b/lib/Target/ARM/ARMFastISel.cpp
> @@ -2662,6 +2662,7 @@ unsigned ARMFastISel::ARMEmitIntExt(MVT SrcVT,
> unsigned SrcReg, MVT DestVT,
>
>    unsigned SrcBits = SrcVT.getSizeInBits();
>    unsigned DestBits = DestVT.getSizeInBits();
> +  (void) DestBits;
>    assert((SrcBits < DestBits) && "can only extend to larger types");
>    assert((DestBits == 32 || DestBits == 16 || DestBits == 8) &&
>           "other sizes unimplemented");
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130607/04d38e65/attachment.html>


More information about the llvm-commits mailing list