[PATCH] ARM: fix CPS decoding

[Renato Golin]

Hi Amaury,

I'm not proficient with the disassembler, but by the look of your three
patches, it seems you're just filtering out bad encodings. Do they ever get
generated from LLVM? Or is this just a response to MC Hammer?

If they ever get generated, would be good to know why and also fix the
origin, but if it's just safe guards, than I'm happy with all patches,
providing you double checked all encodings (I have to confess I did the
first, but not the others ;).

cheers,
--renato


On 7 June 2013 15:47, Amaury de la Vieuville
<Amaury.DeLaVieuville at arm.com>wrote:

> Hi,
>
> This patch fixes the decoding of CPS in some cases where it is ambiguous
> with QADD.
> CPS is ambiguous with several other instructions, their decoders check
> for pred==0xf but do not check the rest of the encoding, we have to
> check for this in decodeCPSInstruction().
> This is usually done at the call site but I think in this case - as
> there are many of them - it is better to do that directly in the decode
> method of the instruction.
>
> Thanks,
> Amaury
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130607/3b826340/attachment.html>