[llvm] r183540 - Use isxdigit.

Rafael Espindola rafael.espindola at gmail.com
Fri Jun 7 11:05:03 PDT 2013


Author: rafael
Date: Fri Jun  7 13:05:03 2013
New Revision: 183540

URL: http://llvm.org/viewvc/llvm-project?rev=183540&view=rev
Log:
Use isxdigit.

Thanks to Benjamin Kramer for the suggestion.

Modified:
    llvm/trunk/lib/Object/YAML.cpp

Modified: llvm/trunk/lib/Object/YAML.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Object/YAML.cpp?rev=183540&r1=183539&r2=183540&view=diff
==============================================================================
--- llvm/trunk/lib/Object/YAML.cpp (original)
+++ llvm/trunk/lib/Object/YAML.cpp Fri Jun  7 13:05:03 2013
@@ -23,14 +23,6 @@ void yaml::ScalarTraits<object::yaml::Bi
   Val.writeAsHex(Out);
 }
 
-// Can't find this anywhere else in the codebase (clang has one, but it has
-// some baggage). Deduplicate as required.
-static bool isHexDigit(uint8_t C) {
-  return ('0' <= C && C <= '9') ||
-         ('A' <= C && C <= 'F') ||
-         ('a' <= C && C <= 'f');
-}
-
 StringRef yaml::ScalarTraits<object::yaml::BinaryRef>::input(
     StringRef Scalar, void *, object::yaml::BinaryRef &Val) {
   if (Scalar.size() % 2 != 0)
@@ -38,7 +30,7 @@ StringRef yaml::ScalarTraits<object::yam
   // TODO: Can we improve YAMLIO to permit a more accurate diagnostic here?
   // (e.g. a caret pointing to the offending character).
   for (unsigned I = 0, N = Scalar.size(); I != N; ++I)
-    if (!isHexDigit(Scalar[I]))
+    if (!isxdigit(Scalar[I]))
       return "BinaryRef hex string must contain only hex digits.";
   Val = object::yaml::BinaryRef(Scalar);
   return StringRef();





More information about the llvm-commits mailing list