[llvm] r183526 - [llvm-symbolizer] rewrite r183213 in a more clear way

[Alexey Samsonov]

Author: samsonov
Date: Fri Jun  7 10:25:27 2013
New Revision: 183526

URL: http://llvm.org/viewvc/llvm-project?rev=183526&view=rev
Log:
[llvm-symbolizer] rewrite r183213 in a more clear way

Modified:
    llvm/trunk/tools/llvm-symbolizer/LLVMSymbolize.cpp
    llvm/trunk/tools/llvm-symbolizer/LLVMSymbolize.h

Modified: llvm/trunk/tools/llvm-symbolizer/LLVMSymbolize.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-symbolizer/LLVMSymbolize.cpp?rev=183526&r1=183525&r2=183526&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-symbolizer/LLVMSymbolize.cpp (original)
+++ llvm/trunk/tools/llvm-symbolizer/LLVMSymbolize.cpp Fri Jun  7 10:25:27 2013
@@ -64,7 +64,8 @@ ModuleInfo::ModuleInfo(ObjectFile *Obj,
         SymbolAddress == UnknownAddressOrSize)
       continue;
     uint64_t SymbolSize;
-    // Getting symbol size is linear for Mach-O files, so avoid it.
+    // Getting symbol size is linear for Mach-O files, so assume that symbol
+    // occupies the memory range up to the following symbol.
     if (isa<MachOObjectFile>(Obj))
       SymbolSize = 0;
     else if (error(si->getSize(SymbolSize)) ||
@@ -76,7 +77,7 @@ ModuleInfo::ModuleInfo(ObjectFile *Obj,
     // FIXME: If a function has alias, there are two entries in symbol table
     // with same address size. Make sure we choose the correct one.
     SymbolMapTy &M = SymbolType == SymbolRef::ST_Function ? Functions : Objects;
-    SymbolDesc SD = { SymbolAddress, SymbolAddress + SymbolSize };
+    SymbolDesc SD = { SymbolAddress, SymbolSize };
     M.insert(std::make_pair(SD, SymbolName));
   }
 }
@@ -89,14 +90,14 @@ bool ModuleInfo::getNameFromSymbolTable(
     return false;
   SymbolDesc SD = { Address, Address };
   SymbolMapTy::const_iterator it = M.upper_bound(SD);
+  if (it == M.begin())
+    return false;
   --it;
-  // Assume that symbols with zero size are large enough.
-  if (it->first.Addr < it->first.AddrEnd &&
-      it->first.AddrEnd <= Address)
+  if (it->first.Size != 0 && it->first.Addr + it->first.Size <= Address)
     return false;
   Name = it->second.str();
   Addr = it->first.Addr;
-  Size = it->first.AddrEnd - it->first.Addr;
+  Size = it->first.Size;
   return true;
 }
 

Modified: llvm/trunk/tools/llvm-symbolizer/LLVMSymbolize.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-symbolizer/LLVMSymbolize.h?rev=183526&r1=183525&r2=183526&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-symbolizer/LLVMSymbolize.h (original)
+++ llvm/trunk/tools/llvm-symbolizer/LLVMSymbolize.h Fri Jun  7 10:25:27 2013
@@ -82,7 +82,9 @@ private:
 
   struct SymbolDesc {
     uint64_t Addr;
-    uint64_t AddrEnd;
+    // If size is 0, assume that symbol occupies the whole memory range up to
+    // the following symbol.
+    uint64_t Size;
     friend bool operator<(const SymbolDesc &s1, const SymbolDesc &s2) {
       return s1.Addr < s2.Addr;
     }