[llvm] r183521 - Optimize BitVector::all().
Benjamin Kramer
benny.kra at gmail.com
Fri Jun 7 08:15:35 PDT 2013
On 07.06.2013, at 16:52, Jay Foad <jay.foad at gmail.com> wrote:
> On 7 June 2013 15:14, Benjamin Kramer <benny.kra at googlemail.com> wrote:
> + // For the last word check that the lower bits are ones. The unused bits are
> + // always zero.
> + return Bits[NumBitWords(size()) - 1] == ~(~0UL << (Size % BITWORD_SIZE));
>
> This looks like it will do the wrong thing if Size is a multiple of BITWORD_SIZE.
r183525. Thanks for the review!
- Ben
More information about the llvm-commits
mailing list