vector data types support in the LLVM interpreter part 3

Duncan Sands duncan.sands at gmail.com
Fri Jun 7 05:27:36 PDT 2013


Hi Yuri,

On 07/06/13 14:07, Veselov, Yuri wrote:
> Hi,
>
> This is the third part of code which implements vector support for LLVM
> interpreter.
>
> Intel uses the interpreter to create a validation tool chain for OpenCL
> compilers (see http://llvm.org/devmtg/2013-04/#talk10)
>
> This patch implements vector support for operations for cast operations (zext,
> sext, uitofp, sitofp, trunc, fpext, fptosi, fptrunc, bitcast) and shift
> operations (shl, ashr, lshr) forinteger and floating point data types and tests.
>
> The clang-format (with –style=LLVM) has been run over the code, so patch
> includes the changes made by this tool as well.

please please don't do this, it just makes your patch harder to review as the
significant parts are drowned in a mass of formatting changes.  You may
know which changes matter, but the reviewer has to wade through them all,
working out what is a formatting change and what (maybe hidden in the
middle of formatting changes) is not.  So can you please send in multiple
patches, one with real changes, the other with formatting only changes,
instead.

Thanks, Duncan.

>
> Patch was implemented on llvm trunk and patched trunk has been built by clang.
>
> Thanks,
>
> Yuri
>
> *Best regards,*
>
> *Yuri Veselov*
>
> INNL, Nizhny Novgorod, Russia
>
> '/+7(831)/*296**-9**4**-**44**;*/ext./*2307*
>
> ***Yuri.Veselov at Intel.com
>
>
> --------------------------------------------------------------------
> Closed Joint Stock Company Intel A/O
> Registered legal address: Krylatsky Hills Business Park,
> 17 Krylatskaya Str., Bldg 4, Moscow 121614,
> Russian Federation
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>




More information about the llvm-commits mailing list